[ENG-2002] redirect user who is already registered #9450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
nero-wolfe-fix
branch
from
91af7d4
to
5c15c6e
Compare
Johnetordoff
changed the title
corbinSanders
approved these changes
Aug 5, 2020
brianjgeiger
requested changes
Aug 5, 2020
tests/test_views.py
Outdated
| assert_equal(self.user.email_verifications, {}) | ||
|
|
||
| res = self.app.get(url, auth=self.auth) | ||
| assert_equal(res.status_code, 302, 'redirects to cas logout') |
There was a problem hiding this comment.
Is this a correct comment? It looks like it's redirecting to the logged in dashboard.
There was a problem hiding this comment.
yeah it's wrong, it's a good old copy and paste error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Orcid sign on causing "bad token" sentry errors, I believe this is because the
email_verificationsis cleared when the user registers, so users attempting to register twice (knowingly do to button mashings or unknowingly due to email spam checking) have no token inemail_verificationshence the error.Changes
QA Notes
No Migration, low risk
To reproduce replicate steps 1, 3 and 4 from this doc: https://docs.google.com/document/d/1wCk_nHQKCVozGk0j0UrU2VFWiF6Qk4qsIYaDzNezjvU/edit
Documentation
馃悶 fix, no docs.
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/ENG-2002