[ENG-2111] Unregistered Contributor Claim on Registration also claims on Project #9472
Conversation
… is user is claimed on registration
There was a problem hiding this comment.
Hmmm. So this is definitely doing what the ticket asked for, but it's a bit odd because it should already be happening. If I make two projects, add the unregistered contributor (with email address) to both, then claim one of those, I claim both of them. It's supposed to search for all unregistered contributors on any project and claim them.
Could you add a test case where you have a second node, unrelated to the one you're registering, that has that unclaimed user as well, and see if it picks up both nodes when the user claims on the registration? If so, this should be fine. If not, we might need to do a bit more digging to see what's going on.
| @@ -733,6 +733,9 @@ def claim_user_registered(auth, node, **kwargs): | |||
| if should_claim: | |||
| node.replace_contributor(old=unreg_user, new=current_user) | |||
| node.save() | |||
| if isinstance(node, Registration): | |||
| project = node.registered_from | |||
| project.replace_contributor(old=unreg_user, new=current_user) | |||
There was a problem hiding this comment.
What happens if the user is removed from the project before they have a chance to claim on the registration?
|
I added that test case and it fails. Based off the test and the code here, I don't think that claiming an unregistered contributor on a given project claims the unregistered contributor on all nodes, currently. I can add that logic in this PR, I'm thinking of iterating through the unclaimed records on the unregistered contributor when they are claimed to replace the unregisterd contributor with the claiming contributor. Sound good/in line with your expectations @brianjgeiger? |
|
Give it a test on a staging environment. Set up two projects, invite someone by email address, and have them claim on one project. When I did it, both projects were claimed. I think it works already for projects, but I'm not sure why it doesn't for registrations. |
|
I just tested it on staging and the unclaimed contributor is only claimed on the project they explicitly claimed, not on other projects the unclaimed contributor is a contributor. |
|
Hmmmm. |
|
I retested this on staging.osf.io and experienced the same results while testing the registered contributor claiming the unregistered contributor initially on the second project the unregistered contributor was added to (rather than the first which I did last time). It has been my continued experience that a registered contributor claiming an unregistered contributor solely claims the unregistered contributor on the specific project the action was made. Creating a new ticket to fix this issue or expanding the scope of this ticket to fix that issue appear to be the best ways forward. |
Purpose
Currently, when an unregistered contributor is claimed by a registered user, the unregistered contributor is not also claimed on the project the registration is based upon.
Changes
QA Notes
This can be tested through the UI. Follow the same workflow specified in the JIRA ticket expecting the contributor to be modified on the project as well.
Documentation
N/A
Side Effects
N/A
Ticket
JIRA Ticket