New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-2280] Adds storage limit status messaging to file notifications #9561
base: develop
Are you sure you want to change the base?
[ENG-2280] Adds storage limit status messaging to file notifications #9561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one tiny question
This private project is ${storage_limit_context['storage_limit_status']} the 5GB OSF Storage limit and requires your attention. In order to avoid disruption of your workflow, please take action through one of the following options:<br> | ||
<ul> | ||
<li>Connect an <a href="https://help.osf.io/hc/en-us/sections/360003623833-Storage-add-ons">OSF Storage add-on</a> to continue managing your research efficiently from OSF. OSF add-ons are an easy way to extend your storage space while also streamlining your data management workflow.</li> | ||
<li>Free up space by making one or more of your components public. <a href="https://help.osf.io/hc/en-us/articles/360019737614-Create-Components">Organize your project with components</a> to take advantage of the flexible structure and maximize storage options.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the "organize your project" bit be its own list entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be combined! Here's the doc I adapted the language from (https://docs.google.com/document/d/1gB5Ya4InmZ3ozOQND1E-drVxnwYJZmzlfV1ohqwr-kQ/edit#bookmark=id.oty6uwnocayh); there are some modifications because we decided to include the storage messaging in file notifications.
Purpose
Notifies admins on a given project if the project is approaching or over OSF Storage limits. This is necessary because admin contributors may not see initially see or be notified if the project is approaching OSF Storage limits.
Changes
file_updated.html.mako
file_updated.html.mako
to use storage_limit_context to selectively show storage usage messagingQA Notes
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
N/A
Side Effects
N/A
Ticket
JIRA Ticket