Fixing email template [ENG-2401] #9570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
brianjgeiger
approved these changes
Dec 7, 2020
…ent command (CenterForOpenScience#9567) ## Purpose This management command was originally calling `add_reviews_notification_setting('new_pending_submissions')`, which was attempting to create a new subscription object on every user in the OSF. This subscription should exist on the providers, not the individual users. The remainder of the command was correctly creating and populating the required subscriptions ## Changes remove the unneeded call
## Purpose Make sure we have tests that actually attempt to render the email templates with the provided context. ## Changes * Updated mocking strategies for `test_sanctions.py` and `test_registration_moderation_notifications.py` to actually call `send_email` and `store_emails`. * Fixed a longstanding bug where the non_admin email wasn't being sent for EmbargoTerminationApprovals * Fixed other email formatting things that came up in the meantime as targets of opportunity ## Ticket https://openscience.atlassian.net/browse/ENG-2451
…tion [ENG-2453] (CenterForOpenScience#9568) ## Purpose The API needs to return the withdrawal justification as the comment in the withdrawal action. Its not doing this right now ## Changes Ensure the registration model saves the withdrawal justification as the action comment. ## QA Notes Please make verification statements inspired by your code and what your code touches. - Verify the API returns the withdrawal justification made by the registration admin in the API - Verify What are the areas of risk? N/A Any concerns/considerations/questions that development raised? N/A ## Documentation N/A ## Side Effects N/A ## Ticket https://openscience.atlassian.net/browse/ENG-2453
corbinSanders
force-pushed
the
feature/fix_reviews_update_comment_email
branch
from
ff4eef7
to
157fb14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
reviews_update_comment.html.mako has incorrect language.
Changes
Fixing reviews_update_comment.html.mako
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk? N/A
Any concerns/considerations/questions that development raised? N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-2401