[SVCS-421] Remove unsizable response reader flag #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag breaks chunked encoding. It appears to no longer be needed either
cslzchen
approved these changes
Jan 3, 2018
[SVCS-421] Update style, use HTTPStatus and fix typo
cslzchen
approved these changes
Jan 3, 2018
|
👍, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/SVCS-421
A continuation of #273
Purpose
The purpose of this PR is the remove the superfluous unsizable argument from the response reader safely and change the stream size behavior to make more sense.
Changes
Side effects
None that I know of.
QA Notes
Download a file from each of the following providers:
These all use size as a positional argument.
Deployment Notes
None.