Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVCS-499] Adding size_as_int property to BaseFileMetadata #312

Closed
wants to merge 5 commits into from
Closed

[SVCS-499] Adding size_as_int property to BaseFileMetadata #312

wants to merge 5 commits into from

Conversation

TomBaxter
Copy link
Member

Ticket

SVCS-499

Purpose

Some provider metadata returns size as a string, not an int. Add a property that returns size as an int.

Changes

Added size_as_int field to BaseFileMetadata.
Added explicit metadata tests for the new property

Side effects

None

QA Notes

This change is very minimal and should require little QA. It should be most notable in the tests for now.

Deployment Notes

None

@coveralls
Copy link

coveralls commented Dec 21, 2017

Coverage Status

Coverage increased (+0.01%) to 89.922% when pulling b235eb1 on TomBaxter:feature/SVCS-499 into 1b60f40 on CenterForOpenScience:develop.

Copy link
Contributor

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loves the elegant try ... except ... that handles different cases. LGTM and move to PCR. 🎆 🎆

  • There is no usage though. I guess we will update related providers after this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants