Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event models #50

Merged
merged 8 commits into from
Apr 24, 2024

Conversation

lukavdplas
Copy link
Contributor

Update the models for events.

Adds EventDescription (i.e. an event description in a source text) -> close #32

As agreed in our last meeting, this removes a lot of the internal structure of events, so we're not so much modelling events as just giving an overview of passages in narrative sources. I removed the modelling of causal links, as well as the idea of breaking up an event into atomic "actions".

So the result is:

  • EventDescription describes a passage in a source text, and you can link the source's descriptions of agents/spaces/objects to it. That's basically all the internal structure it has.
  • Since the case_study app is used for more high-level abstractions, I did add an Episode model there. Could still be useful for linking passages?
  • Also added "key sites" and "key persons" to a case study, which is more a light suggestion. I thought this would be useful in building an interface for a case study. E.g. for the nun rebellion, the Abbey in Poitiers could be a "key site" from which you can explore the data.

This was linked to issues Apr 18, 2024
@lukavdplas lukavdplas marked this pull request as ready for review April 18, 2024 11:53
Base automatically changed from feature/source-description-split-2-contd to develop April 18, 2024 11:54
@lukavdplas lukavdplas merged commit 5527b57 into develop Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Episode model Split entity models into source-based and historical
1 participant