Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code into module base class and add template engine to merge code #39

Closed
wants to merge 16 commits into from

Conversation

AdeMiller
Copy link
Contributor

This is based on #24 and as per my comments there creates a base class and then uses a template engine to add the base class code and a copyright header to all files. standardization.md contains a brief explanation.

So far I've only done clc_aa_policy and its tests but everything works. I've already discovered some places where the existing shared methods are out of sync and some other potential duplication of code.

     14     def __init__(self, module):
     13     def _set_clc_credentials_from_env(self):
     11     def _set_user_agent(clc):
     11     def _define_module_argument_spec():
      3     def _wait_for_requests_to_complete(self, requests_lst):
      3     def _get_servers_from_clc(self, server_list, message):
      3     def define_argument_spec():
      2     def _wait_for_requests(module, request_list):
      2     def _refresh_servers(module, servers):
      2     def _get_alert_policy_id_by_name(clc, module, alias, alert_policy_name):
      2     def _find_network_id(module, datacenter):
      2     def _find_datacenter(clc, module):
      2     def _add_alert_policy_to_server(

@AdeMiller AdeMiller closed this May 6, 2016
@AdeMiller AdeMiller deleted the base_template branch May 6, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants