Transistion property fix #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue with csstidy using the transition property where it would strip the "s" or "ms" from 0 .. e.g. "0s" becomes "0" (a unitless zero). It would only happen for "0s" not "0.4s", for example. According to the standards and browser tests, the transition property fails because of the stripped unit.
TobiasBg
added a commit
to TablePress/TablePress
that referenced
this pull request
Feb 25, 2017
Cerdic
pushed a commit
that referenced
this pull request
Sep 29, 2017
+ unit test This resolves an issue with csstidy using the transition property where it would strip the "s" or "ms" from 0 .. e.g. "0s" becomes "0" (a unitless zero). It would only happen for "0s" not "0.4s", for example. According to the standards and browser tests, the transition property fails because of the stripped unit.
|
Thanks again! This patch is now merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue with csstidy using the transition property where it would strip the "s" or "ms" from 0 .. e.g. "0s" becomes "0" (a unitless zero). It would only happen for "0s" not "0.4s", for example. According to the standards and browser tests, the transition property fails because of the stripped unit.
Issue #41