Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for signum bus authentication #53

Merged
merged 3 commits into from
Nov 5, 2022
Merged

Add support for signum bus authentication #53

merged 3 commits into from
Nov 5, 2022

Conversation

Cereal2nd
Copy link
Owner

@Cereal2nd Cereal2nd commented Nov 1, 2022 •
edited
Loading

  • controller.connect parse the url to support tls://@:
  • a way to send the auth key towards the bus

@Cereal2nd Cereal2nd marked this pull request as ready for review November 1, 2022 20:18
@Cereal2nd Cereal2nd requested a review from niobos November 4, 2022 17:00
niobos
niobos approved these changes Nov 4, 2022
View reviewed changes
velbusaio/protocol.py Outdated Show resolved Hide resolved
@Cereal2nd
Copy link
Owner Author

Cereal2nd commented Nov 5, 2022 •
edited
Loading

testing actions:

  • serial connection
  • tcp:ip (non-signum server
  • tls://host:port (signum without auth)
  • tls://auth@host:port (signum with authentication)

@Cereal2nd Cereal2nd merged commit a9f1449 into master Nov 5, 2022
@Cereal2nd Cereal2nd deleted the signumAuth branch November 5, 2022 13:22
@Cereal2nd Cereal2nd mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niobos niobos niobos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cereal2nd @niobos