remove reference to increaseAllowance #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarittenen
approved these changes
Feb 5, 2024
|
LGTM - also having a commented out check for it seems not such a bad idea if it comes up a lot, but probably usage will be waning: OpenZeppelin/openzeppelin-contracts#4583 Hopefully other common situations will be handled by some EIP and we can just put the vanilla checks in a EIPXXX.spec for other cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed reference to the function
increaseAllowancein theERC20.spec.The function
increaseAllowanceis not a standard ERC20 function (see list here https://ethereum.org/developers/docs/standards/tokens/erc-20). It created a bad error message on m0's code when Jared tried to run the rule on their code, which had an ERC20 that did not contain this function:[main] ERROR ALWAYS - Error in spec file (ERC20.spec:102:80): could not type expression "sig:MToken.increaseAllowance(address, uint256)", message: could not find methodhttps://prover.certora.com/output/7053/8a687fb3ff0e4b06b5c357738a5e8340/?anonymousKey=5cb589114f221eaf6c38bde67e7824d55686a0f5
As we want this spec to be generic, I am removing the reference to this function.