Skip to content

Commit

Permalink
fix: always convert char, varchar, and text parameters to their Unico…
Browse files Browse the repository at this point in the history
…de equivalent

this allows the server to handle mapping extended ASCII characters into the correct
codepage for a given column without needing to pre-check collation settings

Fixes typeorm#7932
  • Loading branch information
Ceshion committed Jul 22, 2021
1 parent 870ac67 commit ca57c5b
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/driver/sqlserver/SqlServerQueryRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2244,15 +2244,12 @@ export class SqlServerQueryRunner extends BaseQueryRunner implements QueryRunner
case "tinyint":
return this.driver.mssql.TinyInt;
case "char":
return this.driver.mssql.Char(...parameter.params);
case "nchar":
return this.driver.mssql.NChar(...parameter.params);
case "text":
return this.driver.mssql.Text;
case "ntext":
return this.driver.mssql.Ntext;
case "varchar":
return this.driver.mssql.VarChar(...parameter.params);
case "nvarchar":
return this.driver.mssql.NVarChar(...parameter.params);
case "xml":
Expand Down

0 comments on commit ca57c5b

Please sign in to comment.