Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary GPU instance metadata example #53

Merged
merged 2 commits into from Aug 2, 2022

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Jul 27, 2022

A PRELIMINARY state of an example that uses EXT_mesh_gpu_instancing and EXT_structural_metadata.

GpuInstanceMetadata gif

The sandcastle for accessing the data uses a private API. When there is a public API, this example can be updated.

@lilleyse
Copy link
Contributor

This is a nice surprise!

You should be able to use EXT_instance_features to avoid the private API.

If you feel like taking this further you could add another sample that has multiple feature ID sets

image

@javagl
Copy link
Contributor Author

javagl commented Jul 27, 2022

Yes, I also mentioned that at https://community.cesium.com/t/from-i3dm-to-ext-mesh-gpu-instancing/19731/2 (which was the reason for reviving the model that I started back in #40 (comment) ...). I'll try to do the update soon, but will have to do some local updates/extensions (sic) to properly support EXT_instance_features...

@javagl
Copy link
Contributor Author

javagl commented Aug 1, 2022

The sample has been finalized and added to the main README.

Since it neither belongs to EXT_mesh_features nor to EXT_structural_metadata, but combines multiple extensions, I think it makes sense to put it directly into a subdirectory of the glTF directory. But if desired, the layout can be adjusted.

Entry point: https://github.com/javagl/3d-tiles-samples/tree/add-gpu-instance-metadata-example/glTF#other-gltf-extensions

@javagl javagl marked this pull request as ready for review August 1, 2022 23:07
@lilleyse
Copy link
Contributor

lilleyse commented Aug 2, 2022

👍

@lilleyse lilleyse merged commit 380bbd4 into CesiumGS:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants