Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for glTF extension validation #70

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Sep 25, 2023

This PR accompanies the PR at CesiumGS/3d-tiles-validator#280

The changes that are done here:

  • The GltfUtilities contained a function extractJsonFromGlb that only sliced out the JSON buffer from a glTF 1.0 or glTF 2.0 GLB file. There was not function for obtaining the binary buffer. This has been generalized into a function extractDataFromGlb that returns the JSON buffer and the binary buffer.
  • The BinaryPropertyTable originally contained the propertyTable and individual properties that together defined the binary representation of the metadata (independent of whether it was part of a property table or not). The parts that define the binary metadata have now been summarized in a BinaryMetadata structure.
  • The handling of ENUM properties and their binary representation had some issues that are supposed to be fixed here. Details are given in Binary representations of enum values are not translated #71

@javagl
Copy link
Contributor Author

javagl commented Oct 9, 2023

I'll mark this as 'Ready For Review' now. The relevant changes (beyond additional, 'internal exports' that are required for the validator) are summarized in the first comment. This will be part of the change log of the next (minor) release that is supposed to be used for CesiumGS/3d-tiles-validator#280

@javagl javagl marked this pull request as ready for review October 9, 2023 16:56
@lilleyse lilleyse merged commit 47c92b9 into main Oct 10, 2023
2 checks passed
@lilleyse lilleyse deleted the gltf-extension-validation-updates branch October 10, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants