Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vctr format: feature table dos not have "BATCH_LENGTH" field #379

Closed
ryanliang000 opened this issue Jul 20, 2019 · 4 comments
Closed

Vctr format: feature table dos not have "BATCH_LENGTH" field #379

ryanliang000 opened this issue Jul 20, 2019 · 4 comments

Comments

@ryanliang000
Copy link

ryanliang000 commented Jul 20, 2019

Currently, every polygon/polyline/point has a feature properties, it is costly somehow.
I think we need add "BATCH_LENGTH" field to feature table to identify the feature length. Then we can make some polygons or polylines belong to one batchid.
Also the b3dm format already has a "BATCH_LENGTH" field in its feature table.

// current code from Vector3DTileContent.js line 325-330
var numberOfPolygons = defaultValue(featureTableJson.POLYGONS_LENGTH, 0);
..
var totalPrimitives = numberOfPolygons + numberOfPolylines + numberOfPoints;
var batchTable = new Cesium3DTileBatchTable(content, totalPrimitives, batchTableJson, batchTableBinary, createColorChangedCallback(content));

@ryanliang000 ryanliang000 changed the title Vctr formart: feature table not have BATCH_LENGTH field Vctr formart: feature table dosnot have "BATCH_LENGTH" field Jul 20, 2019
@jbo023
Copy link
Contributor

jbo023 commented Aug 6, 2019

Ho, we are also really interested in this topic.

At the moment it is not possible to group Features in MultiGeometries.
The proposed change to use BATCH_LENGTH instead of the calculated property totalPrimitives sounds like a good solution?

@jbo023
Copy link
Contributor

jbo023 commented Oct 11, 2019

do you have any remarks/ideas about this ?

@OmarShehata
Copy link

Thanks for the suggestion! The vector tiles format is still a draft, I've labelled this as "vector data" to make sure this use case is considered when there's more progress on the standard. You can also watch the vector tiles roadmap here: #25

@pjcozzi pjcozzi changed the title Vctr formart: feature table dosnot have "BATCH_LENGTH" field Vctr format: feature table dos not have "BATCH_LENGTH" field Nov 15, 2021
@lilleyse
Copy link
Contributor

Yes this is an omission in the old vctr spec. This will be handled properly in a future vector tile format CC #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants