External tileset #45
Merged
External tileset #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new section looks good to me. |
|
Thanks @lilleyse. @e-andersson any comments based on your implementation experience? |
|
@pjcozzi I can make the figure but it may not happen tomorrow. When do you need it? |
|
Looks good. It might be helpful to add a note somewhere on how to use empty tiles to create the kind of tree needed for the global tileset of tilesets described, but perhaps that'll come with the coming figure. |
|
@slchow next week is OK, no rush. @e-andersson I agree the figure will help. @lilleyse and I also plan to write a series of tutorials showing how the flexibility of 3D Tiles can be used for diverse use cases like this, see CesiumGS/cesium#3241. You are also welcome to write a tutorial if you would like. |
Merged
|
@slchow added the figure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42.
@e-andersson and @lilleyse please review. See the new "External Tilesets" section.
@slchow can you please create a figure similar to CesiumGS/cesium#3237 (comment) in the same style as your other figures for the remaining TODO? The legend in the top left and the caption at the bottom does not need to be part of the figure.
Merge #44 first. This change is only one commit: 6f0637a