Globe anchor support #453
Merged
Globe anchor support #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weegeekps orientations are all looking good in my tests! |
weegeekps
requested review from
lilleyse,
r-veenstra,
corybarr and
mattelser
as code owners
lilleyse
reviewed
Oct 5, 2023
exts/cesium.usd.plugins/cesium/usd/plugins/CesiumUsdSchemas/__init__.pyi
Outdated
Show resolved
Hide resolved
exts/cesium.omniverse/cesium/omniverse/ui/attributes/globe_anchor_attributes_widget.py
Outdated
Show resolved
Hide resolved
exts/cesium.omniverse/cesium/omniverse/ui/attributes_widget_controller.py
Show resolved
Hide resolved
exts/cesium.usd.plugins/cesium/usd/plugins/CesiumUsdSchemas/_cesiumUsdSchemas.so
Outdated
Show resolved
Hide resolved
lilleyse
reviewed
Oct 5, 2023
| @@ -754,4 +831,23 @@ RenderStatistics Context::getRenderStatistics() const { | |||
| return renderStatistics; | |||
| } | |||
|
|
|||
| void Context::addGlobeAnchorToPrim(const pxr::SdfPath& path) { | |||
There was a problem hiding this comment.
From offline discussion: are globe anchors added to the registry when loaded from a file? Do we need to watch for globe anchors in processPrimAdded?
There was a problem hiding this comment.
As discussed during stand-up, I will be fixing this in a subsequent PR. I opened #489 for this.
|
@lilleyse I'm ready for you to take a second pass at this when you're able. In the morning I'm going to fix the things I left untouched today. |
lilleyse
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #235.
This PR implements Globe Anchor support for any Xformable prims via a custom API schema. When a user adds a Globe Anchor to a prim, a new transform op with a
cesiumsuffix is added. This transform is used by the anchoring code to place the object in the USD stage. User's can use the transformation widgets as normal, or can set an exact Geographic Coordinate using either Lat/Long/Alt or ECEF. Updating any one of these values updates all of the others.NOTE: I plan on squashing and merging this PR due to the sheer number of commits, but I'm leaving them here so we can keep the history.
2023-10-04.17-38-22.mp4