Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple ion servers in UI #591

Merged
merged 2 commits into from Dec 15, 2023
Merged

Conversation

lilleyse
Copy link
Contributor

Fixes #562.

Follow up to #578 that adds a cesium ion server selector in the UI. There are still a few UI components that are not addressed in this PR but will come in a follow up:

In addition, there are some bugs related to saving and loading:

  • Saving a .usda with multiple servers for the first time causes a server disconnect
  • Loading a .usda with multiple servers doesn't resume the connection

Projects with the single default ion server don't seem to have these issues, which is good.

Also...

  • Creating a new project always requires connecting to ion. That's because there's no existing connection to resume. I think this is expected behavior, but would have to verify with Cesium for Unreal.

Finally, while I started to implement something that would query the ion api url automatically, this didn't really work with the existing code. @r-veenstra any tutorial content will need to be updated so that the api url is filled in instead of left blank. E.g. for https://self-hosted.cesium.com/ it would be https://api.self-hosted.cesium.com/.

Obviously there are a lot of improvements to make here still, but it's certainly usable. Here I add CWT from ion.cesium.com and GTOPO from self-hosted.cesium.com.

self-hosted-omniverse.mp4

Base automatically changed from update-cesium-native to main December 15, 2023 00:52
Copy link
Contributor

@r-veenstra r-veenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this all appears to be working in my testing, with exception to the bugs and limitations outlined in the PR.

I have noticed one additional issue where the "Create a new token" option in the Token UI doesn't appear to create tokens with self hosted, but works ok with regular ion.

@lilleyse lilleyse merged commit a4c0fb2 into main Dec 15, 2023
3 checks passed
@lilleyse lilleyse deleted the multiple-servers-ui branch December 15, 2023 01:49
@lilleyse
Copy link
Contributor Author

Creating a new project always requires connecting to ion. That's because there's no existing connection to resume. I think this is expected behavior, but would have to verify with Cesium for Unreal.

This is fixed in #594. It should no longer sign you out each time. What was happening was that the property change notifications here were triggering a disconnect here. Since property change notifications are now ignored after prim add notifications, this no longer happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI for selecting current ion server
2 participants