Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Cesium3DTileset Inspector #77

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented Oct 31, 2022

This should be merged after #76. I noticed while changing the ion asset ID / access token in the Cesium3DTileset's inspector that it would trigger OnValidate() after every single character change, which was annoying when I was typing a longer asset ID into the field. Since this needed to be done anyway for some of the options (i.e. disabling irrelevant fields depending on toggled options), I went ahead and created a custom version of the inspector.

It should appear the same as the default inspector, but now there are two buttons at the top: Refresh Tileset and Troubleshoot Token. The ion Asset ID and ion Access Token fields don't process the user's changes until they have pressed enter / clicked outside of the text field. Additionally, changing some enums / toggles disables other options. For example, selecting From Url as a tileset's data source disables the ion fields.

image

@j9liu j9liu changed the base branch from main to ion-troubleshooting-ui October 31, 2022 21:26
@j9liu
Copy link
Contributor Author

j9liu commented Oct 31, 2022

While comparing the UI with the one in Unreal Engine, I realized we forgot an option for showCreditsOnScreen. I added that just now, though it's rendering incorrectly:

image

I'll debug this in a later PR.

Base automatically changed from ion-troubleshooting-ui to main November 1, 2022 21:39
@j9liu j9liu merged commit 4d7a854 into main Nov 1, 2022
@j9liu j9liu deleted the custom-tileset-inspector branch November 1, 2022 21:39
@j9liu
Copy link
Contributor Author

j9liu commented Nov 11, 2022

While comparing the UI with the one in Unreal Engine, I realized we forgot an option for showCreditsOnScreen. I added that just now, though it's rendering incorrectly:

image

I'll debug this in a later PR.

Turns out this is exactly how it appears in Cesium for Unreal, so it seems like something would have to be adjusted in cesium-native.

image

In particular, I'm not sure why the delimiter is counted as credit, both in cesium-native and in CesiumJS 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant