-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewing the Globe #37
Conversation
Thanks Ben! Sorry for the delayed review on this. I noticed a few things while testing in standalone:
|
Thank you @xuelongmu! Great points. The dragging functionality has been removed for now and will be added in after some fine tuning so that it runs smoothly. The Earth viewer now positions the earth in front of the player while transitioning, but after that you can move freely around the globe or rotate it with thumbstick input. Ready for re-review. |
Thanks @CesiumBen! This looks great overall. Few minor things: On the Similar feedback, it seems like the EarthViewer component should be able to update its own position on Tick rather than have the developer remember to put it on its owning actor's Tick. This comment in the SetEarthView function would also make a bit more sense: as after reading that comment, I was looking for a Tick function on the component but that functionality is handled on the tick of the owning actor. Finally, quick naming thing - BP_EarthViewer should have Component appended to the end. |
Thanks @xuelongmu, updates below
Updated, thanks for catching that
I've updated the "SetEarthViewCoordinates" function to also set the Earth in view, moving that functionality from the input graph. I also added in a check to only set the Earth in view if you are in Earth view, so that if you're in normal view you can update safely update your coordinates without any Earth visualization.
I've moved it to the tick of its own component, earlier control of that tick was needed because of the grabbing which is no longer applied. In the future we'd want to disable tick of the component dynamically. |
This looks great Ben! Merging now. |
Summary
This PR adds the dragging the globe functionality.
Author checklist
Testing plan
Open up the dragging the globe level and grab the earth with either grip trigger. Test moving the head around as well.
In the main level you can return to normal view by teleporting on the Earth by pointing to teleport as you normally would on the ground. While in the main level you can also enter the "Earth View" mode by flying high enough.
Reminders for reviewers
Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author. Please keep these points in mind throughout the review process: