Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging error #44

Merged
merged 4 commits into from Jun 28, 2023
Merged

Fix packaging error #44

merged 4 commits into from Jun 28, 2023

Conversation

xuelongmu
Copy link
Contributor

@xuelongmu xuelongmu commented Jun 20, 2023

Summary

When packaging the project, there was an error as reported on the forums. The error was due to the SavedLocations variable in BP_TutorialSaveGame not being marked as a "save game" variable in the properties. This is now resolved as seen below, and the game is packaging successfully.

image

Author checklist

  • Tutorial for N/A
  • Has the new tutorial been integrated into the main level? N/A
  • Has a new section of the readme been added for this tutorial? Not needed
  • Have you done a full self-review of the code and blueprints? Yes
  • Have you tagged a primary reviewer? Yes
  • Are there any remaining tasks to do or blocking questions to answer before we can merge this? No

Testing plan

Set the game default map to BuildForQuest in the Project Settings -> Maps & Modes
Package the the BuildForQuest map for Android as follows:
image

Reminders for reviewers

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author. Please keep these points in mind throughout the review process:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand why this code change fixes the issue and agree that it's the best approach to doing so.
  • Review the automated tests and make sure there are no missing tests or edge cases.
  • When you feel this is ready bump it to a second reviewer or merge.

@xuelongmu xuelongmu requested a review from CesiumBen June 20, 2023 19:08
@xuelongmu xuelongmu self-assigned this Jun 20, 2023
@CesiumBen
Copy link
Contributor

@xuelongmu I was able to package an android application as expected.

@CesiumBen CesiumBen merged commit afc28e9 into main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants