Use correct default for glTF occlusion texture. #1102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CesiumGlTFFunction material function has an incorrect default for the
occlusionTexture
. As a result, a glTF model without an explicit occlusion texture (which is most of them) will have anAmbient Occlusion
value of 0.0, rather than 1.0 as expected. Under certain lighting setups, this can make shadows cast onto the model extremely dark (basically pure black).This PR fixes it by changing the default texture to one that has the value 1.0 in the red channel. Specifically, from this (
NoMetallicRoughnessTexture
):To this (
NoColorTexture
):(Thanks @AlbanBERGERET-Epic for reporting this!)