Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimport 1x1 textures as 4x4 #1225

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Reimport 1x1 textures as 4x4 #1225

merged 6 commits into from
Apr 17, 2024

Conversation

joseph-kaile
Copy link
Collaborator

The tile sets are black in 5.3 iOS for some unknown reason. Resizing the 1x1 textures to 4x4 textures makes the issue go away.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a driveby comment -- probably should rename this to transparent4x4 since it is no longer 1x1 :)

@csciguy8
Copy link
Contributor

Fix seems to relate to
#1391

... although nothing in the Unreal docs explicitly say that 1x1 textures are to be avoided...
https://docs.unrealengine.com/4.27/en-US/RenderingAndGraphics/Textures/SupportAndSettings/

image

@CesiumGS CesiumGS deleted a comment from cesium-concierge Apr 17, 2024
@CesiumGS CesiumGS deleted a comment from cesium-concierge Apr 17, 2024
@azrogers
Copy link
Contributor

Reverted my code changes, it's a lot easier to just get this in with just the asset changes than to rename the assets, rename their usage in the code, make sure other assets still point to it correctly, etc... and I don't think the name transparent1x1 is really going to cause that much confusion.

@azrogers azrogers merged commit 15b7c39 into main Apr 17, 2024
17 of 18 checks passed
@azrogers azrogers deleted the fix-black-texture-iphone branch April 17, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants