-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FeatureId::propertyTable usage to fit with cesium-native changes #1431
Conversation
Thanks @azrogers ! I'll wait for CI to pass before I merge. |
Unfortunately it seems like iOS isn't happy with the recent cesium-native changes :/ It seems like these are the culprits:
|
I fixed the above by updating cesium-native to inclue CesiumGS/cesium-native#891, so merge that first. |
This PR now updates cesium-native to include CesiumGS/cesium-native#892 too. |
This looks ready to go. I'll merge unless there are objections... |
FeatureId::propertyTable
is now no longer an std::optional, which requires a few small changes.