Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated FloatingPawn and CesiumGlobeAnchorParent #454

Merged
merged 3 commits into from
May 28, 2021

Conversation

xuelongmu
Copy link
Contributor

@xuelongmu xuelongmu commented May 24, 2021

@cesium-concierge
Copy link

Thanks for the pull request @xuelongmu!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

@kring
Copy link
Member

kring commented May 28, 2021

This looks good to me. I confirmed that cesium-unreal-samples, which of course includes a FloatingPawn, pops up a message when it's loaded but otherwise still works correctly. The message says:

LoadErrors: Warning: FloatingPawn_C /Game/CesiumSamples/Maps/01/01_CesiumWorld.01_CesiumWorld:PersistentLevel.FloatingPawn_18: class /CesiumForUnreal/FloatingPawn.FloatingPawn_C has been deprecated.

@kring kring merged commit 479ab22 into main May 28, 2021
@kring kring deleted the deprecate-globe-anchor branch May 28, 2021 03:36
@xuelongmu
Copy link
Contributor Author

I did some testing today and can confirm that the warning shows up, but floating pawn still works correctly. Additionally, if you try to compile the deprecated blueprint, it'll fail to compile, and afterwards if you try to play in-game there will be a BLUEPRINT COMPILE ERROR log message that shows up in the top left, but again this doesn't seem to affect the functionality. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate FloatingPawn and CesiumGlobeAnchorParent
3 participants