Added maximumCachedBytes as a UPROPERTY

[shikharvashistha]

Greetings of the day @kring,

Please review the PR and let me know in case of any changes if required.
Fixes : #633

• Signed CLA

[cesium-concierge]

Thanks for the pull request @shikharvashistha!

• ✔️ Signed CLA found.
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

• Cesium for Unreal Samples works.

[kring]

Hi @shikharvashistha, thanks for the PR! Don't worry about the CI failure (it currently doesn't work from external PRs). Before this can be said to fix #633, though, it needs a couple of things:

1. The maxiumCachedBytes needs to be copied into the TilesetOptions instance. Take a look at how MaximumScreenSpaceError is handled.
2. The default value and comments should be copy/pasted from TilesetOptions source code in cesium-native: https://github.com/CesiumGS/cesium-native/blob/a8f39d8cc6a45e2c5b845d4f596394e02b1e6cf7/Cesium3DTilesSelection/include/Cesium3DTilesSelection/TilesetOptions.h#L160

[shikharvashistha]

Hi @shikharvashistha, thanks for the PR! Don't worry about the CI failure (it currently doesn't work from external PRs). Before this can be said to fix #633, though, it needs a couple of things:

1. The maxiumCachedBytes needs to be copied into the TilesetOptions instance. Take a look at how MaximumScreenSpaceError is handled.
2. The default value and comments should be copy/pasted from TilesetOptions source code in cesium-native: https://github.com/CesiumGS/cesium-native/blob/a8f39d8cc6a45e2c5b845d4f596394e02b1e6cf7/Cesium3DTilesSelection/include/Cesium3DTilesSelection/TilesetOptions.h#L160

@kring Done !

[shikharvashistha]

Travis CI Logs

C:/Users/travis/build/CesiumGS/packages/CesiumForUnreal/HostProject/Plugins/CesiumForUnreal/Source/CesiumRuntime/Private/Cesium3DTileset.cpp(1220): error C2039: 'MaximumCachedBytes': is not a member of 'Cesium3DTilesSelection::TilesetOptions'
    C:\Users\travis\build\CesiumGS\packages\CesiumForUnreal\HostProject\Plugins\CesiumForUnreal\Source\ThirdParty\include\Cesium3DTilesSelection/TilesetOptions.h(56): note: see declaration of 'Cesium3DTilesSelection::TilesetOptions'
    C:/Users/travis/build/CesiumGS/packages/CesiumForUnreal/HostProject/Plugins/CesiumForUnreal/Source/CesiumRuntime/Private/Cesium3DTileset.cpp(1220): error C2039: 'maximumCachedBytes': is not a member of 'ACesium3DTileset'

[javagl]

The capitalization is reversed in this line. It is

options.MaximumCachedBytes = static_cast<int64_t>(this->maximumCachedBytes); but should be
options.maximumCachedBytes = static_cast<int64_t>(this->MaximumCachedBytes);

Also, the default value for the MaximumCachedBytes is currently 256, but should be 256 * 1024 * 1024 (256 Megabytes/mebibytes)

[shikharvashistha]

The capitalization is reversed in this line. It is

options.MaximumCachedBytes = static_cast<int64_t>(this->maximumCachedBytes); but should be
options.maximumCachedBytes = static_cast<int64_t>(this->MaximumCachedBytes);

Also, the default value for the MaximumCachedBytes is currently 256, but should be 256 * 1024 * 1024 (256 Megabytes/mebibytes)

Fixed ! 👍

[kring]

Just those two small things left @shikharvashistha and then we'll merge this. Thanks for sticking with it.

[kring]

Looks like you've removed the options.maximumCachedBytes assignment entirely. You need that, it's only the cast you don't need.

[kring]

Thanks @shikharvashistha!