Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampleTerrain and SampleTerrainMostDetailed regression on thrown errors #11694

Open
ggetz opened this issue Dec 13, 2023 · 0 comments
Open

SampleTerrain and SampleTerrainMostDetailed regression on thrown errors #11694

ggetz opened this issue Dec 13, 2023 · 0 comments

Comments

@ggetz
Copy link
Contributor

ggetz commented Dec 13, 2023

Historically, SampleTerrain and SampleTerrainMostDetailed would reject if a 404 error was thrown. At some point in time (I assume with #10149), this behavior broke and a cartographic with undefined height is returned instead.

Sandcastle

To throw a bit of a wrench into the gears, #11530 has since been added, unknowingly adding an opt-in flag to replicate the previous behavior.

We will likely remove or change the default for that flag and restore the older behavior where an error would cause the promise returned by the function to reject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant