Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in unit tests in headless mode #11733

Closed
ptrgags opened this issue Jan 3, 2024 · 1 comment
Closed

Race condition in unit tests in headless mode #11733

ptrgags opened this issue Jan 3, 2024 · 1 comment

Comments

@ptrgags
Copy link
Contributor

ptrgags commented Jan 3, 2024

in #11718, one commit (and only one commit) had an error that seems to be a race condition in afterAll(), See this CI build

Locally I can reproduce this by running the same command. It seems to happen much more consistently on my laptop.

npm run test -- --browsers ChromeHeadless --failTaskOnError --webgl-stub --release --suppressPassed

My output (different than in CI):

Chrome Headless 119.0.6045.159 (Linux x86_64) ERROR
  An error was thrown in afterAll
  Unhandled promise rejection: undefined thrown
Chrome Headless 119.0.6045.159 (Linux x86_64) ERROR
  An error was thrown in afterAll
  Unhandled promise rejection: undefined thrown
1.217 secs: DataSources/PolygonGeometryUpdater Computes dynamic geometry bounding sphere for fill.
1.036 secs: DataSources/KmlDataSource NetworkLink: onInterval
0.764 secs: DataSources/ModelVisualizer computes bounding sphere with height reference clamp to ground
0.468 secs: DataSources/SampledProperty mergeNewSamples works with huge data sets.
0.332 secs: Core/sampleTerrain with terrain providers should handle the RequestScheduler throttling the requestTileGeometry requests with a retry
0.29 secs: Core/sampleTerrainMostDetailed queries heights
0.245 secs: Core/CesiumTerrainProvider requestTileGeometry Uses query parameter extensions for ion resource
0.193 secs: DataSources/RectangleGeometryUpdater Computes dynamic geometry bounding sphere for fill.
0.162 secs: Core/sampleTerrain requires terrainProvider, level, and positions
0.156 secs: DataSources/ModelVisualizer fails bounding sphere when sampleTerrainMostDetailed fails

Chrome Headless 119.0.6045.159 (Linux x86_64): Executed 7693 of 14044 (skipped 2) ERROR (13.319 secs / 11.735 secs)

[16:49:53] 'test' errored after 19 s
[16:49:53] Error: 1
    at formatError (/home/ptrgags/git/cesium/node_modules/gulp-cli/lib/versioned/^4.0.0/format-error.js:21:10)
    at Gulp.<anonymous> (/home/ptrgags/git/cesium/node_modules/gulp-cli/lib/versioned/^4.0.0/log/events.js:33:15)
    at Gulp.emit (node:events:529:35)
    at Gulp.emit (node:domain:489:12)
    at Object.error (/home/ptrgags/git/cesium/node_modules/undertaker/lib/helpers/createExtensions.js:61:10)
    at handler (/home/ptrgags/git/cesium/node_modules/now-and-later/lib/map.js:50:14)
    at f (/home/ptrgags/git/cesium/node_modules/once/once.js:25:25)
    at f (/home/ptrgags/git/cesium/node_modules/once/once.js:25:25)
    at tryCatch (/home/ptrgags/git/cesium/node_modules/async-done/index.js:24:15)
    at done (/home/ptrgags/git/cesium/node_modules/async-done/index.js:40:12)
@ggetz
Copy link
Contributor

ggetz commented Jan 4, 2024

I believe this is a duplicate of #11231.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants