Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

camera.flyToBoundingSphere doesn't respect range when radius is zero #2519

Closed
alexander-entin opened this issue Feb 26, 2015 · 1 comment · Fixed by #2528
Closed

camera.flyToBoundingSphere doesn't respect range when radius is zero #2519

alexander-entin opened this issue Feb 26, 2015 · 1 comment · Fixed by #2528
Labels
type - bug

Comments

@alexander-entin
Copy link

https://github.com/AnalyticalGraphicsInc/cesium/blob/1.6/Source/Scene/Camera.js#L2490-L2495
I'd say it should be wrapped with
if (!offset.range) { ... }
to only change the range if it wasn't provided
@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 27, 2015

Thanks for the report.

mramato added a commit that referenced this issue Mar 2, 2015
@mramato
camera.flyToBoundingSphere should always use range when it's supplied
db29e1d 
Fixes #2519

I also tweaked `distanceToBoundingSphere2D` because it was giving
incorrect results on my machine.
@mramato mramato mentioned this issue Mar 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type - bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

camera.flyToBoundingSphere should always use range when it's supplied CesiumGS/cesium
2 participants
@pjcozzi @alexander-entin