New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D Tiles - ModelInstanceCollection has no ShadowMode option to conserve performance. #4340
Comments
Thanks for submitting this, adding a |
The implementation for this looks to be very easy, mostly adding another parameter called shadows, adding this._shadows below the variables that get passed onto the model and adding it to the createModel function's parameters for the model. This seems to do the trick. |
This is a possible solution for Issue CesiumGS#4340.
Changed a typo, changed position of some lines to adhere to consistency and added a getter/setter property shadows for the active model within the ModelInstanceCollection to edit shadows in runtime instead of only on creation.
Fixed in #4341 |
Per Request - Added our Organization details and my name to Contributors.md
Hi,
Currently I'm using openstreetmaps to load forestdata to use for rendering trees in cesium using the ModelInstanceCollection of the 3D Tiles branch. The problem is that the ModelInstanceCollection has no options for setting the ShadowMode of the models contained within. Some of the objects in our scene require the shadows, and the trees are more there for cosmetic value so disabling shadows in the general sense of Cesium is not an option for us. Adding a shadowmode option to the ModelInstanceCollection might help in regards to usage and performance. It seems checked off in #3241 but isn't implemented. I tested it by adding it in our local branch and it seems to work well (only really tested with the ShadowMode.ENABLED and ShadowMode.DISABLED).
Kind regards,
Heerco
The text was updated successfully, but these errors were encountered: