Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KML sandcastle demo really slow in IE #4415

Closed
hpinkos opened this issue Oct 7, 2016 · 2 comments
Closed

KML sandcastle demo really slow in IE #4415

hpinkos opened this issue Oct 7, 2016 · 2 comments

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Oct 7, 2016

Reported on the forum: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/ko8w1DEhjgU

This is especially slow in loading the second GDP example. The user says when toggling between the first and second example he expeienced an out of memory error after a few times.

http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=KML.html&label=DataSources

@mramato
Copy link
Contributor

mramato commented Oct 7, 2016

IE11 has known memory leaks that Microsoft has officially closed as "won't fix" since IE is in the barest of support mode.

Same issues with performance, while the KML demo overall could use performance improvements, IE will always be significantly slower than other browsers. Our official recommendation is don't use IE11 unless you absolutely have to.

That all being said, we can do a pass here to see if any obvious problems pop up, but I don't expect any miracles to happen and more likely than not; it's just IE being IE.

@mramato
Copy link
Contributor

mramato commented Oct 19, 2016

Looking into this the core of the problem is that the clampToGround code basically takes forever. This is partially because IE is incredibly slow and partially because our code has some inefficiencies and bugs which are covered by other issues and will get addressed this wee at the bash.

However, clampToGrond shouldn't even be happening for this demo because it defaults to false. It turns out that we are not taking this setting into account when handling KML labels and billboards, so I'm going to open a PR to fix that issue which will allow us to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants