Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Tiles 1.0 Updates #6697

Closed
6 of 7 tasks
lilleyse opened this issue Jun 18, 2018 · 12 comments
Closed
6 of 7 tasks

3D Tiles 1.0 Updates #6697

lilleyse opened this issue Jun 18, 2018 · 12 comments

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Jun 18, 2018

These are the updates required to load tilesets defined by the 3D Tiles 1.0 spec.
@ggetz if you think of others feel free to add to this list.

Now:

Later:

@lilleyse
Copy link
Contributor Author

In the near future we should also go through all the items in #5363 and remove the deprecation checks.

@ggetz
Copy link
Contributor

ggetz commented Jun 18, 2018

@lilleyse I double checked and this list seemed comprehensive. The only thing else I can think of is if the padding clarifications require any implementation changes, which I don't believe they do.

@lilleyse
Copy link
Contributor Author

Loading a 1.0 tileset came up on the forum: https://groups.google.com/forum/#!topic/cesium-dev/8zJhev5Vh5w.

I reordered the list so the most important items for compatibility are first.

@hpinkos
Copy link
Contributor

hpinkos commented Jul 19, 2018

@lilleyse all of our tilesets used in Sandcastle generate deprecation warnings. Is fixing that part of this roadmap issue?

@ggetz
Copy link
Contributor

ggetz commented Jul 19, 2018

@hpinkos #5504

3d-tiles-tools has been updated to generate 1.0 tilesets, so we should be good to at least get rid of the sandcastle tilesets that throw deprecation warnings before the next release.

@mramato
Copy link
Contributor

mramato commented Jul 30, 2018

Just a reminder that the release is this Wednesday. We should really try and get all showstopper issues addressed by the end of today.

@tfili
Copy link
Contributor

tfili commented Jul 31, 2018

Is this going to make it in for tomorrow?

@ggetz
Copy link
Contributor

ggetz commented Jul 31, 2018

Yes, finishing these up now, see #6862 and #6861 (comment)

I think that covers all sandcastle tilesets.

@tfili
Copy link
Contributor

tfili commented Jul 31, 2018

What about the extra tasks under later? Do you want to write a new issue or just remove the Next Release tag on this one?

@mramato
Copy link
Contributor

mramato commented Jul 31, 2018

We really should be writing small issues, no roadmaps. Roadmaps make everything super opaque and hard to fine.

@lilleyse
Copy link
Contributor Author

Ok this is good to close now.

@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/8zJhev5Vh5w

If this issue affects any of these threads, please post a comment like the following:

The issue at #6697 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants