Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TerrainFillMesh unit tests fail under Firefox Headless (and maybe others) #8068

Open
mramato opened this issue Aug 15, 2019 · 5 comments
Open

Comments

@mramato
Copy link
Contributor

mramato commented Aug 15, 2019

Under Firefox Headless (and possibly other options) a bunch of TerrainFillMeshSpec unit tests fail with the below error:

renderState.lineWidth is out of range.  Check minimumAliasedLineWidth and maximumAliasedLineWidth.

Not sure if this is exposing a bug in our code we previously missed, or if the test is just bad.

@mramato mramato added type - bug good first issue An opportunity for first time contributors labels Aug 15, 2019
@dave-b-b
Copy link

Is this one still needing to be resolved? If so, I can take it.

@ggetz
Copy link
Contributor

ggetz commented Aug 23, 2024

@dave-b-b Please confirm if this is still an issue by running npm test -- --browsers Firefox. See the Testing Guide for more info.

The actual fix for this may be more involved depending on the result of the test.

@dave-b-b
Copy link

Okay. I'll take a look and update here.

@dave-b-b
Copy link

These are the tests that failed. Sorry it took so long.
Failed tests.pdf

@ggetz ggetz added test failure and removed good first issue An opportunity for first time contributors type - bug labels Aug 27, 2024
@ggetz
Copy link
Contributor

ggetz commented Aug 27, 2024

No worries, thanks @dave-b-b! It looks like this has escalated to a larger issue. I've updated the labels accordingly, and removed the "goof first issue" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants