Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color.fromCssColorString fails with leading or trailing spaces #9015

Closed
angrycat9000 opened this issue Jul 2, 2020 · 0 comments · Fixed by #9027
Closed

Color.fromCssColorString fails with leading or trailing spaces #9015

angrycat9000 opened this issue Jul 2, 2020 · 0 comments · Fixed by #9027
Labels
good first issue An opportunity for first time contributors

Comments

@angrycat9000
Copy link
Contributor

Passing a string with leading or trailing spaces, such as ' rgb( 108, 136, 255)', returns undefined. This same string is accepted by the browser when setting a CSS color. The regex should be adjusted to accept leading or trailing spaces.

Sandcastle example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Color.fromCssColorString when color string contains spaces sambakk/cesium
1 participant
@angrycat9000