Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Color.fromCssColorString when color string contains spaces #9027

Merged
merged 9 commits into from Jul 21, 2020

Conversation

sambakk
Copy link
Contributor

@sambakk sambakk commented Jul 12, 2020

Fixes #9015

@cesium-concierge
Copy link

Thanks for the pull request @sambakk!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Specs/Core/ColorSpec.js Outdated Show resolved Hide resolved
@hpinkos
Copy link
Contributor

hpinkos commented Jul 20, 2020

Thanks for the PR @sambakk! That was my only comment

@hpinkos
Copy link
Contributor

hpinkos commented Jul 20, 2020

Oh, also please add a comment about this to CHANGES.md under the Fixes section

@sambakk
Copy link
Contributor Author

sambakk commented Jul 20, 2020

Thanks for the PR @sambakk! That was my only comment

You're welcome @hpinkos, I updated the PR as requested.

@hpinkos hpinkos merged commit 37c19e7 into CesiumGS:master Jul 21, 2020
@hpinkos
Copy link
Contributor

hpinkos commented Jul 21, 2020

Thanks for the contribution @sambakk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color.fromCssColorString fails with leading or trailing spaces
3 participants