Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packArray() for Matrix types #10118

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Add packArray() for Matrix types #10118

merged 5 commits into from
Feb 18, 2022

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Feb 18, 2022

To make the MatrixN API more consistent with CartesianN, I added packArray() and unpackArray(). I also updated the unit tests for matrices to use createPackableSpecs and createPackableArraySpecs() for consistency.

This change is needed for #10116, since EXT_structural_metadata supports arrays of matrices.

@lilleyse could you review?

@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Source/Core/Matrix2.js Show resolved Hide resolved
Source/Core/Matrix4.js Outdated Show resolved Hide resolved
Specs/Core/Matrix3Spec.js Outdated Show resolved Hide resolved
@ptrgags
Copy link
Contributor Author

ptrgags commented Feb 18, 2022

@lilleyse updated!

@lilleyse lilleyse merged commit 2289162 into main Feb 18, 2022
@lilleyse lilleyse deleted the matrix-pack-array branch February 18, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants