Affine transformation helpers functions for Matrix classes
#10124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @IanLilleyT!
Reviewers, don't forget to make sure that:
|
IanLilleyT
force-pushed
the
matrixFunctions
branch
2 times, most recently
from
015aec3
to
e0df525
Compare
IanLilleyT
force-pushed
the
matrixFunctions
branch
from
e0df525
to
674f059
Compare
|
Thanks @IanLilleyT! @ebogo1 can you please review? |
ebogo1
reviewed
Feb 23, 2022
| const scaleRatioX = scale.x / existingScale.x; | ||
| const scaleRatioY = scale.y / existingScale.y; | ||
|
|
||
| result[0] = matrix[0] * scaleRatioX; |
There was a problem hiding this comment.
Could this just call multiplyByScale like Matrix4 does? Unless this is what you meant by inlining more of the math.
|
|
||
| const scale = Matrix2.getScale(matrix, scaleScratch4); | ||
|
|
||
| result[0] = rotation[0] * scale.x; |
There was a problem hiding this comment.
Same here - there are a couple other places in this file so I'll stop commenting on each one. Maybe the uniformScale function doesn't need it because it's not using a scratch vec2.
|
Yep the inline math is intended and should give slightly better performance and IMO doesn't hurt readability. There are some areas in this PR where the function was already implemented but I changed it to be inline math for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills in some gaps in
Matrix2,Matrix3, andMatrix4for affine transformations. This includes:setScale- forMatrix2,Matrix3Matrix4alreadysetUniformScale- forMatrix2,Matrix3,Matrix4multiplyByUniformScale- forMatrix2,Matrix3Matrix4alreadysetRotation- forMatrix2,Matrix3,Matrix4getRotation- forMatrix2,Matrix4Matrix3alreadyfromRotation- forMatrix4Matrix2andMatrix3already have their own versions of thisAlso did some cleanup in the specs so that all tests are grouped by:
Misc: