Fix REPLACE styling for glTF without pbrMetallicRoughness object #10424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that
Cesium3DTileColorBlendMode.REPLACE
wasn't working for certain tilesets. Specifically, if a glTF material omitted thepbrMetallicRoughness
object then the style would not get applied.Why....? The code uses a special
_3DTILESDIFFUSE
semantic to figure out which attribute or uniform should be replaced with the feature color. Usually it attaches itself to the vertex color attribute, base color texture, or base color factor, but in this case none of those could be found.The fix was to add a uniform for the default
baseColorFactor
value. The semantic gets added to that and everything works again.As a side note, this bug doesn't seem to affect
ModelExperimental
which handles things very differently.