Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix per-feature post-processing with ModelExperimental #10528

Merged
merged 2 commits into from Jul 8, 2022
Merged

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Jul 8, 2022

the Sandcastles "Per-Feature Post Processing" and "Custom Per-Feature Post Processing" were not working correctly when ModelExperimental was used.

The fix was simple, there was a missing private getter model.pickIds.

@j9liu could you review?

@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@j9liu
Copy link
Contributor

j9liu commented Jul 8, 2022

@ptrgags looks good, I confirmed this works with the Custom Per-Feature Post Process and Per-Feature Post Processing sandcastles!

Just waiting on Travis to pass, then I'll merge

@j9liu j9liu merged commit 20940b5 into main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants