Workers as ESM, remove RequireJS

.eslintignore

@@ -17,8 +17,6 @@ packages/engine/Build/**
 packages/engine/Source/Scene/GltfPipeline/**
 packages/engine/Source/Shaders/**
 packages/engine/Source/ThirdParty/**
-packages/engine/Source/Workers/**
-!packages/engine/Source/Workers/transferTypedArrayTest.js
 
 # packages/widgets
 packages/widgets/Build/**

.prettierignore

@@ -28,9 +28,6 @@ packages/engine/index.js
 packages/engine/Source/Scene/GltfPipeline/**
 packages/engine/Source/Shaders/**/*.js
 packages/engine/Source/ThirdParty/**
-packages/engine/Source/Workers/**/*
-!packages/engine/Source/Workers/cesiumWorkerBootstrapper.js
-!packages/engine/Source/Workers/transferTypedArrayTest.js
 
 packages/widgets/Build/**
 packages/widgets/index.js

CHANGES.md

@@ -4,6 +4,11 @@
 
 #### @cesium/engine
 
+##### Breaking Changes :mega:
+
+- Firefox 114 is now the minimum Firefox version required to run CesiumJS. [#11400](https://github.com/CesiumGS/cesium/pull/11400)
+- `TaskProcessor` now loads worker files as ESM instead of AMD. [#11400](https://github.com/CesiumGS/cesium/pull/11400)
+
 ##### Fixes :wrench:
 
 - Fixed issue where terrain with multiple layers was loading higher LOD tiles inconsistently. [#11312](https://github.com/CesiumGS/cesium/issues/11312)

LICENSE.md

@@ -270,18 +270,6 @@ https://github.com/sole/tween.js
 >
 > THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-### RequireJS
-
-https://github.com/jrburke/requirejs
-
-> Copyright (c) 2010-2015, The Dojo Foundation
->
-> Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
->
-> The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
->
-> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
 ### Knockout
 
 http://knockoutjs.com/

Specs/BadGeometry.js

@@ -1,7 +1,7 @@
 import { queryToObject, RuntimeError } from "@cesium/engine";
 
 function BadGeometry() {
-  this._workerName = "../../Specs/TestWorkers/createBadGeometry";
+  this._workerName = "../../Build/Specs/TestWorkers/createBadGeometry";
 
   // Make this worker loadable when testing against the built version of Cesium.
   if (

Specs/TestWorkers/.eslintrc.json

@@ -1,10 +1,6 @@
 {
-  "extends": "../.eslintrc.json",
-  "env": {
-      "amd": true
-  },
-  "parserOptions": {
-      "ecmaVersion": 2015,
-      "sourceType": "script"
-  }
+  "extends": "cesium/browser",
+  "plugins": [
+    "es"
+  ]
 }

Specs/TestWorkers/createBadGeometry.js

@@ -1,7 +1,5 @@
-define(function () {
-  "use strict";
+import { createTaskProcessorWorker } from "@cesium/engine";
 
-  return function () {
-    throw new Error("BadGeometry.createGeometry");
-  };
+export default createTaskProcessorWorker(function () {
+  throw new Error("BadGeometry.createGeometry");
 });

Specs/TestWorkers/returnByteLength.js

@@ -1,9 +1,5 @@
-define(["Workers/createTaskProcessorWorker"], function (
-  createTaskProcessorWorker
-) {
-  "use strict";
+import { createTaskProcessorWorker } from "@cesium/engine";
 
-  return createTaskProcessorWorker(function (parameters, transferableObjects) {
-    return parameters.byteLength;
-  });
+export default createTaskProcessorWorker(function (parameters) {
+  return parameters.byteLength;
 });

Specs/TestWorkers/returnNonCloneable.js

@@ -1,11 +1,7 @@
-define(["Workers/createTaskProcessorWorker"], function (
-  createTaskProcessorWorker
-) {
-  "use strict";
+import { createTaskProcessorWorker } from "@cesium/engine";
 
-  return createTaskProcessorWorker(function (parameters, transferableObjects) {
-    return function () {
-      //functions are not cloneable
-    };
-  });
+export default createTaskProcessorWorker(function () {
+  return function () {
+    //functions are not cloneable
+  };
 });

Specs/TestWorkers/returnParameters.js

@@ -1,9 +1,5 @@
-define(["Workers/createTaskProcessorWorker"], function (
-  createTaskProcessorWorker
-) {
-  "use strict";
+import { createTaskProcessorWorker } from "@cesium/engine";
 
-  return createTaskProcessorWorker(function (parameters, transferableObjects) {
-    return parameters;
-  });
+export default createTaskProcessorWorker(function (parameters) {
+  return parameters;
 });

Specs/TestWorkers/returnWasmConfig.js

@@ -1,9 +1,6 @@
-define([], function () {
-  "use strict";
+import { createTaskProcessorWorker } from "@cesium/engine";
 
-  return function returnWasmConfig(event) {
-    const data = event.data;
-    const wasmConfig = data.webAssemblyConfig;
-    self.postMessage(wasmConfig);
-  };
+export default createTaskProcessorWorker(function returnWasmConfig(parameters) {
+  const wasmConfig = parameters.webAssemblyConfig;
+  return wasmConfig;
 });

Specs/TestWorkers/throwError.js

@@ -1,9 +1,5 @@
-define(["Workers/createTaskProcessorWorker"], function (
-  createTaskProcessorWorker
-) {
-  "use strict";
+import { createTaskProcessorWorker } from "@cesium/engine";
 
-  return createTaskProcessorWorker(function (parameters, transferableObjects) {
-    throw new Error(parameters.message);
-  });
+export default createTaskProcessorWorker(function (parameters) {
+  throw new Error(parameters.message);
 });

Specs/TestWorkers/transferArrayBuffer.js

@@ -1,11 +1,10 @@
-define(["Workers/createTaskProcessorWorker"], function (
-  createTaskProcessorWorker
-) {
-  "use strict";
+import { createTaskProcessorWorker } from "@cesium/engine";
 
-  return createTaskProcessorWorker(function (parameters, transferableObjects) {
-    const arrayBuffer = new ArrayBuffer(parameters.byteLength);
-    transferableObjects.push(arrayBuffer);
-    return arrayBuffer;
-  });
+export default createTaskProcessorWorker(function (
+  parameters,
+  transferableObjects
+) {
+  const arrayBuffer = new ArrayBuffer(parameters.byteLength);
+  transferableObjects.push(arrayBuffer);
+  return arrayBuffer;
 });

ThirdParty.extra.json

@@ -69,12 +69,6 @@
     {
         "name": "rbush"
     },
-    {
-        "name": "requirejs",
-        "license": ["MIT"],
-        "version": "2.1.20",
-        "url": "https://www.npmjs.com/package/requirejs"
-    },
     {
         "name": "topojson-client"
     },

ThirdParty.json

@@ -44,7 +44,7 @@
     "license": [
       "Apache-2.0"
     ],
-    "version": "3.0.3",
+    "version": "3.0.4",
     "url": "https://www.npmjs.com/package/dompurify",
     "notes": "dompurify is available as both MPL-2.0 OR Apache-2.0"
   },
@@ -158,7 +158,7 @@
     "license": [
       "BSD-3-Clause"
     ],
-    "version": "7.2.3",
+    "version": "7.2.4",
     "url": "https://www.npmjs.com/package/protobufjs"
   },
   {
@@ -169,14 +169,6 @@
     "version": "3.0.1",
     "url": "https://www.npmjs.com/package/rbush"
   },
-  {
-    "name": "requirejs",
-    "license": [
-      "MIT"
-    ],
-    "version": "2.1.20",
-    "url": "https://www.npmjs.com/package/requirejs"
-  },
   {
     "name": "topojson-client",
     "license": [