Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue with polygon hole rendering #11577

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Fixes an issue with polygon hole rendering #11577

merged 3 commits into from
Nov 1, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Oct 20, 2023

Fixes #11583

This fixes an issue with polygon hole rendering that was introduced in https://github.com/CesiumGS/cesium/pull/11497/files. Holes were being projected to a slightly different tangent plane than the outer ring, which could result in slightly different coordinate systems between 2D outer positions and holes when triangulating holes with earcut.

You can see the error in the CZML Polygon demo.

Also reported on the forum with an example.

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggetz! The change makes sense, and it fixes the problematic Sandcastles on my machine.

@jjhembd jjhembd merged commit aa90487 into main Nov 1, 2023
9 checks passed
@jjhembd jjhembd deleted the fix-polygon-holes branch November 1, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multipolygon rendering incorrectly
3 participants