Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum required attribution for Google 3D Tiles #11589

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Oct 26, 2023

By default, createGooglePhotorealistic3DTileset no longer shows credits on screen, as this is compliant with the minimum required attribution. Traditionally CesiumJS uses the minimum necessary to be compliant as to avoid any confusion about what is required.

To restore this behavior, pass the option showCreditsOnScreen: true.

@ggetz ggetz requested a review from jjhembd October 26, 2023 13:57
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ggetz!

@jjhembd jjhembd merged commit 8f2dd52 into main Nov 1, 2023
9 checks passed
@jjhembd jjhembd deleted the google-attribute branch November 1, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants