updating Camera.changed to account for changes in roll #11844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @malaretv! I can confirm we have a CLA on file for you. |
ggetz
reviewed
Feb 21, 2024
| camera._changed.raiseEvent( | ||
| Math.max(rollChangedPercentage, headingChangedPercentage) | ||
| ); | ||
| return; |
There was a problem hiding this comment.
I noticed there is no early return in the heading check previously. I believe this is because the function needs to clone the frustum before exiting, as is done below.
There was a problem hiding this comment.
Ah that makes sense. I'll remove the early return since previous behavior was okay.
I was trying to avoid the event maybe being fired multiple times, but maybe that is a non-issue -- or at the very least outside the scope of this one.
Thanks for the review!
ggetz
reviewed
Feb 21, 2024
|
Thank you for the review @ggetz . I've addressed the one comment |
|
Looks good! Thanks @malaretv! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I attempted to fix the remaining issues with #9365, which I think was closed prematurely.
Current behavior: For cases where camera is not pointed straight down to surface twistLeft/Right do not cause a Camera changed event to fire.
Attempted fix: Add a similar check performed for
headingto be also performed forroll. This seems to properly cause the change event to be triggered. I do not know if this is the most optimal fix, just copying what was done by others to handle this case too.Issue number and link
#9365 Can open a new issue if appropriate
Testing plan
I added a test case that listens for the Camera changed event for twistLeft after first telling the camera to lookUp by 45deg. This test failed before my changes, and passed after my changes.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change