Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance bug with many tilesets #11878

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Fix performance bug with many tilesets #11878

merged 3 commits into from
Mar 14, 2024

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Mar 12, 2024

Description

Pointed out on the forum. This was an oversight on my part in #11837.

Issue number and link

N/A

Testing plan

  1. Verify before and after performance of OP's Sandcastle
  2. Verify collision still works for google tilesets

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @ggetz!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor Author

ggetz commented Mar 13, 2024

@jjspace Would you mind taking a look? This branch has already been validated for fixing the original issue by the forum poster.

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, confirmed the change improves performance on the sandcastle from the forums

Edit: I just pushed a fix for the merge conflict, will merge when green again

@jjspace jjspace merged commit 7278123 into main Mar 14, 2024
9 checks passed
@jjspace jjspace deleted the tileset-performance-fix branch March 14, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants