Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP translations #12015

Merged
merged 1 commit into from
Jun 3, 2024
Merged

JP translations #12015

merged 1 commit into from
Jun 3, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Jun 3, 2024

Description

#12013 was meant to have some translations for the dropdown labels but I wasn't clear about that in the PR. Translations provided by @Mizuki0522

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

github-actions bot commented Jun 3, 2024

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@jjhembd
Copy link
Contributor

jjhembd commented Jun 3, 2024

Thanks @jjspace, sorry I missed this in the previous PR

@jjhembd jjhembd merged commit bf44caa into main Jun 3, 2024
10 checks passed
@jjhembd jjhembd deleted the japan-sandcastle branch June 3, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants