Camera events #2704
Camera events #2704
Conversation
|
Did you try re-implementing the GE examples we ported with these events? If not, do you see any issues in doing so? |
| * @type {Number} | ||
| * @default 500.0 | ||
| */ | ||
| this.cameraEventWaitTime = 500.0; |
There was a problem hiding this comment.
To reduce the surface area of the API, perhaps mark this @private until we know we need it?
|
When we merge this, we should search the forum and follow-up in a few places where folks asked for it. @maikuru can you do this? |
For example: https://groups.google.com/forum/#!topic/cesium-dev/AoDahGLCVJY |
|
This fixes #2366. |
No, because I didn't want to update that with a branch off of master. I don't think there will be any issues. |
|
@pjcozzi This is ready for another review. |
|
Last request: can you add this to the Sandcastle example? I know it is duplicate with the ported GE examples, but it will be useful until we better organize everything. |
|
@pjcozzi I added an example. This is ready for another look. |
| @@ -224,6 +253,13 @@ | |||
| scene.primitives.removeAll(); | |||
| scene.tweens.removeAll(); | |||
|
|
|||
| if (Cesium.defined(removeStart)) { | |||
| removeStart(); | |||
There was a problem hiding this comment.
Do we need to set removeStart and removeEnd to undefined?
|
@pjcozzi This is ready. |
|
Sure can. |
Adds
Scene.cameraMoveStartandScene.cameraMoveEndevents.