Use all url templates provided by terrain config file #3038
Conversation
|
Thanks for the contribution, @oterral. I don't believe we have a Contributor's License Agreement (CLA) for you or your organization. Can you send one in? See https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md Also, check out the pull request guidelines in that doc. For example, I imagine we will want to include a unit test and update to CHANGES.md for this change. |
|
Yep I can try. |
|
Great, thanks @oterral. If there's any questions about the CLA, feel free to contact me directly. |
|
We have a CLA now. @kring can you review this? |
|
And a test :) |
| }).then(function() { | ||
| spyOn(loadWithXhr, 'load'); | ||
| provider.requestTileGeometry(0, 0, 0); | ||
| expect(loadWithXhr.load.calls.mostRecent().args[0]).toContain('foo0.ch'); |
There was a problem hiding this comment.
This test is currently failing because the json specifies .com and the test expects .ch. Otherwise this looks good and I'll merge it as soon as the test is fixed.
|
@kring I've fixed the test. |
|
Thanks @oterral! |
Use all url templates provided by terrain config file
|
Thx for the review!!! |
Ready to review.