Instancing models 3d tiles #3059

lilleyse · 2015-10-06T05:30:47Z

First pass of integrating instanced models into 3d-tiles. I'll do a more thorough review later, including cleaning up any TODOs.

pjcozzi · 2015-10-06T13:09:00Z

Apps/Sandcastle/gallery/development/3D Models Instancing 3D Tiles.html

+}
+
+function loadInstanced3DTile() {
+    // TODO : create real tileset later


We'll be able to delete this entire example since the user's code will just load a 3D tileset regardless of the tile format(s) it contains.

pjcozzi · 2015-10-14T15:55:21Z

Source/Renderer/Buffer.js

@@ -6,7 +6,8 @@ define([
        '../Core/destroyObject',
        '../Core/DeveloperError',
        '../Core/IndexDatatype',
-        './BufferUsage'


In order to get more 3D Tiles code into master sooner, can you open a separate pull request into master for these changes and the changes to ShaderProgram.js?

And maybe even the changes to ShaderSource.js (and code that uses it).

pjcozzi · 2015-10-14T16:12:06Z

Source/Scene/Model.js

@@ -2943,9 +2946,6 @@ define([
                                BoundingSphere.clone(command.boundingVolume, pickCommand.boundingVolume);
                            }
                        }
-                    } else {


Why did we delete this? We're actually going to want this for KHR_materials_common and when we support glTF cameras.

CC @tfili

I deleted it because I ended up moving that code to line 2927, which all node types will call.

pjcozzi · 2015-10-14T16:13:29Z

@lilleyse just those comments, then this is ready to merge into the 3D Tiles branch.

…vertex arrays

…avoid ambiguity

lilleyse · 2015-10-23T04:09:16Z

This should be ready for another look now.

I made a few modifications to Model in 948ad72 so that ModelInstanceCollections that point to the same model url can reuse most of the resources except VertexArray. Sharing the cached VertexArray was the source of the bugs I had earlier this week, since all collections would also be sharing the same instance data buffer.

I think I discovered the main memory leak you brought up before, but I would like you to verify this.

The rest of the changes are renaming and organizational.

pjcozzi · 2015-10-23T17:50:44Z

With instancing disabled in the Sandcastle example, the GC is still a problem:

pjcozzi · 2015-10-23T17:52:38Z

When individual models are used, the GC is still at 10.92% so the bulk (or all) of the allocations could be in Model.js. Check to see if this is in master to help narrow it down. In either case, we'll want to fix it.

pjcozzi · 2015-10-23T17:56:53Z

@lilleyse we can merge this once we determine the allocations.

As I mentioned before, I also think we can combine BatchedModel and InstancedModel but let's see how 3D Tiles evolve a bit more first.

pjcozzi · 2015-10-24T12:28:49Z

Moved the GC issues to #3125.

Instancing models 3d tiles

laurensdijkstra · 2016-04-29T14:37:39Z

What is the status of Instanced glTF models? When checking the source code of Cesium master I could not find any reference to instanceCount or ModelInstanceCollection. We would like to draw alot of trees, but the performance is pretty bad.

pjcozzi · 2016-04-30T20:57:19Z

@laurensdijkstra model instancing is in the 3d-tiles branch.

laurensdijkstra · 2016-05-03T07:35:37Z

Thanks @pjcozzi !

lilleyse and others added 19 commits October 5, 2015 14:22

Added Model instancing

3415df3

Whitespace

aecfb3c

Whitespace

37276da

Whitespace

5bab8d6

Tweak doc

a65a038

Fixed jittering by rendering relative to bounding volume

a5add4e

Moved all instancing code into ModelInstanceCollection

791a555

Small fix

b938c61

Tweak comment

33c4acd

Style tweak

02781ce

Style tweak

12904b8

Style tweak

a416ee8

Updated model instancing Sandcastle demo

4f14143

Minor fixes

b48b4f2

Rendering show and color using instanced attributes for now

b820a55

Support color and show when instancing is disabled

13d14c0

Instancing using batch texture

77b2547

Merge branch 'instancing-models' into 3d-tiles

61d5607

Added instanced model 3d tile type

bab0ba9

pjcozzi reviewed Oct 6, 2015
View reviewed changes

pjcozzi mentioned this pull request Oct 6, 2015

Model Instancing #3049

Closed

8 tasks

pjcozzi reviewed Oct 14, 2015
View reviewed changes

Tweak comment

88efe56

pjcozzi reviewed Oct 14, 2015
View reviewed changes

lilleyse added 2 commits October 20, 2015 10:31

Removed Instancing 3D Tiles demo, using Cities instead

be59252

Prevent instance collections from sharing the same Model

bc10897

lilleyse force-pushed the instancing-models-3d-tiles branch from 3b9d78e to bc10897 Compare October 20, 2015 22:01

Reverted previous commit, now share the same Model but create unique …

948ad72

…vertex arrays

lilleyse force-pushed the instancing-models-3d-tiles branch from 5b4bbec to 948ad72 Compare October 21, 2015 19:57

lilleyse added 2 commits October 22, 2015 23:19

Fixed memory leak in non-instanced code path

69b858d

Renamed Cesium3dTileBatchTable to Cesium3DTileBatchTableResources to …

9ae609d

…avoid ambiguity

Removed baseUrl from Cesium3DTileset

a49b6fd

lilleyse force-pushed the instancing-models-3d-tiles branch from 994a391 to a49b6fd Compare October 23, 2015 13:44

Small change

e19f70a

lilleyse force-pushed the instancing-models-3d-tiles branch from d47184e to e19f70a Compare October 23, 2015 15:01

pjcozzi mentioned this pull request Oct 24, 2015

Lots of models leads to high GC usage #3125

Open

pjcozzi added a commit that referenced this pull request Oct 24, 2015

Merge pull request #3059 from lilleyse/instancing-models-3d-tiles

1a62043

Instancing models 3d tiles

pjcozzi merged commit 1a62043 into CesiumGS:3d-tiles Oct 24, 2015

pjcozzi deleted the instancing-models-3d-tiles branch October 24, 2015 12:29

pjcozzi mentioned this pull request Nov 3, 2015

Instanced 3D Model and Composite Tile Formats CesiumGS/3d-tiles#23

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Instancing models 3d tiles #3059

Instancing models 3d tiles #3059

lilleyse commented Oct 6, 2015

pjcozzi Oct 6, 2015

pjcozzi Oct 14, 2015

pjcozzi Oct 14, 2015

pjcozzi Oct 14, 2015

lilleyse Oct 20, 2015

pjcozzi commented Oct 14, 2015

lilleyse commented Oct 23, 2015

pjcozzi commented Oct 23, 2015

pjcozzi commented Oct 23, 2015

pjcozzi commented Oct 23, 2015

pjcozzi commented Oct 24, 2015

laurensdijkstra commented Apr 29, 2016

pjcozzi commented Apr 30, 2016

laurensdijkstra commented May 3, 2016

Instancing models 3d tiles #3059

Instancing models 3d tiles #3059

Conversation

lilleyse commented Oct 6, 2015

pjcozzi Oct 6, 2015

Choose a reason for hiding this comment

pjcozzi Oct 14, 2015

Choose a reason for hiding this comment

pjcozzi Oct 14, 2015

Choose a reason for hiding this comment

pjcozzi Oct 14, 2015

Choose a reason for hiding this comment

lilleyse Oct 20, 2015

Choose a reason for hiding this comment

pjcozzi commented Oct 14, 2015

lilleyse commented Oct 23, 2015

pjcozzi commented Oct 23, 2015

pjcozzi commented Oct 23, 2015

pjcozzi commented Oct 23, 2015

pjcozzi commented Oct 24, 2015

laurensdijkstra commented Apr 29, 2016

pjcozzi commented Apr 30, 2016

laurensdijkstra commented May 3, 2016