Fixes for Ellipsoid.scaleToGeodeticSurface #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Handle case where cartesian is at or near the center of the ellipsoid. 2. For positions at the center, we now return `undefined`. 3. For positions near the center, we now return the result instead of getting stuck in an infinite loop. 4. Fixes #338 by handling case 2 during a morph. 5. Minor cleanup related to above changes. CC @kring @bagnell
| var z2 = positionZ * positionZ; | ||
| //* If the position is near the center, the iteration will not converge. | ||
| if (squaredNorm < this._centerToleranceSquared) { | ||
| return Cartesian3.magnitudeSquared(cartesian) === 0 ? undefined : Cartesian3.clone(intersection, result); |
There was a problem hiding this comment.
This should compare to an epsilon value like CesiumMath.EPSILON20. I was able to get NaNs with
Ellipsoid.WGS84.cartesianToCartographic(new Cartesian3(1.0, 1.0, 1.0).multiplyByScalar(1e-150))
There was a problem hiding this comment.
This is ported from Components and it computes a value there 0.785398163397448, 0.61864960609024, -6370952.8006335. I'll look more into this.
|
Ready for another review. |
|
This looks good to me. Tests pass. @kring Want to review and merge? |
|
Looks good to me as well. Merging. |
kring
added a commit
that referenced
this pull request
Jan 3, 2013
…face Fixes for Ellipsoid.scaleToGeodeticSurface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefined.CC @kring @bagnell