Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed inverseTransposeModel typos #4115

Merged
merged 3 commits into from Aug 9, 2016
Merged

Conversation

andyfry01
Copy link
Contributor

Hello,

I corrected the typo from Issue #3942. The issue only referenced the typo in Model.js line 2132, although there was also a typo (inverseTranposeModel) in UniformState.js line 264. The same typo is also in BuiltinFunctionsSpec lines 28, 39 and 50, should these be corrected?

Thanks,
Andy

@hpinkos
Copy link
Contributor

hpinkos commented Jul 13, 2016

Thanks @andyfry01! I know it's a small change, but can you please send in a CLA so we can merge this?

And yes, I think this typo should be corrected throughout

@andyfry01
Copy link
Contributor Author

Sure thing @hpinkos, I'll fill out a CLA and will also push another commit to change the other typos.

@andyfry01
Copy link
Contributor Author

Hi again @hpinkos,

I removed the MapQuest imagery provider from createDefaultImageryProviderViewModels.js as per issue #4019.

I also corrected the remaining "tranpose" typos in:

Also just emailed my CLA form to the email indicated.

Thanks!
Andy

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 13, 2016

We now have a CLA from @andyfry01. Thanks again for these contributions!

@lilleyse
Copy link
Contributor

lilleyse commented Aug 9, 2016

This looks good to me.

@lilleyse lilleyse merged commit 35685df into CesiumGS:master Aug 9, 2016
@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 9, 2016

Thanks again @andyfry01. I also added you to the list of contributors: 126ac75#diff-f0eaedffe49f98e11072394a678af7cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants